-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] - New merging mode to combine components #11046
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11046 +/- ##
==========================================
- Coverage 92.20% 92.18% -0.02%
==========================================
Files 405 406 +1
Lines 19244 19290 +46
==========================================
+ Hits 17743 17782 +39
- Misses 1134 1139 +5
- Partials 367 369 +2 ☔ View full report in Codecov by Sentry. |
@codeboten @open-telemetry/collector-approvers I would appreciate any feedback you guys might have! |
I think we need to discuss more on #8754 before moving forward with any concrete solution |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Koanf's default merging strategy currently overrides static values such as slices, numbers, and strings. However, lists of components should be treated as a special case. This pull request introduces a new feature gate to allow for merging lists instead of discarding the existing ones.
With this new merging strategy:
service
configuration are merged rather than replaced.service::*
.Link to tracking issue
Related issues:
Testing
Documentation
Note: I’d appreciate your feedback on this 🙏