Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Remove incorrect comment on Factory interface #11017

Merged

Conversation

TylerHelmuth
Copy link
Member

Description

Removes an incorrect comment from the component.Factory interface.

This comment was added via #4338 when the extension/receiver/processor/exporter factory types all still lived in component. Since the factories have been moved to other modules, component.Factory needs to be implementable.

The specific extension/receiver/processor/exporter factory types are unimplementable since they are defined in internal packages.

Link to tracking issue

Related to #6506

@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 29, 2024
@TylerHelmuth TylerHelmuth requested review from a team, codeboten and mx-psi August 29, 2024 21:25
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (6329c24) to head (d42168d).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11017      +/-   ##
==========================================
+ Coverage   91.75%   92.03%   +0.27%     
==========================================
  Files         412      412              
  Lines       19344    19313      -31     
==========================================
+ Hits        17750    17774      +24     
+ Misses       1232     1185      -47     
+ Partials      362      354       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this, while I believe it is technically feasible to make the interface sealed, I feel like the change could be a ~biggish refactor with no clear benefit

@mx-psi mx-psi added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Aug 30, 2024
@mx-psi mx-psi merged commit 6b57a75 into open-telemetry:main Aug 30, 2024
66 of 84 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 30, 2024
@TylerHelmuth TylerHelmuth deleted the component-remove-incorrect-comment branch August 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants