Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] newObsReport is no longer needed #10957

Merged

Conversation

codeboten
Copy link
Contributor

This is leftover from the refactor to make that func private to the package. Removing it as all the callers can use newExporter directly.

this is leftover from the refactor to make that func private to the package. Removing it as all the callers can use newExporter directly.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and TylerHelmuth August 23, 2024 16:06
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.88%. Comparing base (b10029c) to head (271b880).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10957      +/-   ##
==========================================
- Coverage   91.89%   91.88%   -0.01%     
==========================================
  Files         411      411              
  Lines       19311    19309       -2     
==========================================
- Hits        17745    17743       -2     
  Misses       1217     1217              
  Partials      349      349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 11c5071 into open-telemetry:main Aug 26, 2024
49 checks passed
@codeboten codeboten deleted the codeboten/cleanup-unnecessary-func branch August 26, 2024 19:16
@github-actions github-actions bot added this to the next release milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants