remove unnecessary level #10951
Merged
remove unnecessary level #10951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MeterProvider used to generate the matric will make calls to recording the metric Noops. Removing the level check. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/unnecessary-level
branch
from
baef604
to
dca5228
Compare
codeboten
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10951 +/- ##
==========================================
- Coverage 91.89% 91.89% -0.01%
==========================================
Files 411 411
Lines 19318 19311 -7
==========================================
- Hits 17752 17745 -7
Misses 1217 1217
Partials 349 349 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Aug 22, 2024
songy23
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MeterProvider used to generate the matric will make calls to recording the metric Noops. Removing the level check.