[mdatagen] mdatagen support validate metrics in in telemetry section #10942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Aug 22, 2024
| } | ||
| errs = errors.Join(errs, md.validateAttributes(usedAttrs)) | ||
| errs = errors.Join(errs, validateMetrics(md.Metrics, md.Attributes, usedAttrs), | ||
| validateMetrics(md.Telemetry.Metrics, md.Attributes, usedAttrs), |
There was a problem hiding this comment.
Thanks @Frapschen, is there already a unit test that covers this change?
There was a problem hiding this comment.
Yes, please see the changed file cmd/mdatagen/testdata/unused_attribute.yaml, it will make sure the attributes that are used in telemetry.metric will not encounter unused attributes: [xxx] error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10942 +/- ##
==========================================
- Coverage 92.21% 92.19% -0.03%
==========================================
Files 405 405
Lines 19240 19245 +5
==========================================
Hits 17743 17743
- Misses 1130 1133 +3
- Partials 367 369 +2 ☔ View full report in Codecov by Sentry. |
|
Hi @codeboten, PTAL thanks! |
atoulme
reviewed
Sep 4, 2024
codeboten
pushed a commit
that referenced
this pull request
Sep 5, 2024
|
@codeboten just a friendly ping. Please review again. |
codeboten
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a use case, I define an attribute and try to use it in
telemetry.metrichowever I encounter an error:unused attributes: [xxx]So, I push this PR to enhance the
validateMetrics()func to support validate metrics intelemetry.metricLink to tracking issue fix #10925
Fixes #
Testing
Documentation