-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen] add LeveledMeter method #10933
[mdatagen] add LeveledMeter method #10933
Conversation
This func will MeterProvider and MetricsLevel in the near future. Split from open-telemetry#10912 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This will use the LeveledMeterProvider in TelemetrySettings. Split from open-telemetry#10912, follows open-telemetry#10931 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10933 +/- ##
==========================================
- Coverage 91.66% 91.60% -0.07%
==========================================
Files 404 404
Lines 18941 18955 +14
==========================================
Hits 17363 17363
- Misses 1219 1233 +14
Partials 359 359 ☔ View full report in Codecov by Sentry. |
This change makes the
Is the new field expected to be required? If so, should it be marked as a breaking change? |
@codeboten let me know if we need an issue from this? I can create one |
This is expected as the LeveledMeterProvider should be present. Adding a note to the changelog makes sense |
This will use the LeveledMeterProvider in TelemetrySettings.
Split from #10912, follows #10931