Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (deps): migrate rand to rand/v2 #10889

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

webstradev
Copy link
Contributor

Description

Migrated rand dependency to rand/v2. We only use rand in tests and mocks and the only two functions we use are float32 and float64 which still exist in the new v2 API so nothing very exciting going on here.

Link to tracking issue

Fixes #10885

Testing

Ran make test successfully

Documentation

Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
@webstradev webstradev requested review from a team and bogdandrutu August 14, 2024 13:49
@songy23 songy23 requested a review from mx-psi August 14, 2024 13:52
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 14, 2024
@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2024

@webstradev would you be willing to also update the depguard rules? Can be done in this PR if you want to :)

@webstradev
Copy link
Contributor Author

@webstradev would you be willing to also update the depguard rules? Can be done in this PR if you want to :)

Yep will do!

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.65%. Comparing base (d5d1f82) to head (09ad7b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main   #10889       +/-   ##
=========================================
+ Coverage      0   91.65%   +91.65%     
=========================================
  Files         0      405      +405     
  Lines         0    19031    +19031     
=========================================
+ Hits          0    17442    +17442     
- Misses        0     1229     +1229     
- Partials      0      360      +360     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webstradev
Copy link
Contributor Author

Making a small fix for the depguard rule, needs a $ for the specific version.

Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
@webstradev
Copy link
Contributor Author

Making a small fix for the depguard rule, needs a $ for the specific version.

@mx-psi Should be good to go now

@mx-psi mx-psi merged commit 38c8f41 into open-telemetry:main Aug 14, 2024
49 checks passed
@mx-psi
Copy link
Member

mx-psi commented Aug 14, 2024

Thanks!

@github-actions github-actions bot added this to the next release milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to math/rand/v2
2 participants