-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore (deps): migrate rand to rand/v2 #10889
Conversation
Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@webstradev would you be willing to also update the depguard rules? Can be done in this PR if you want to :) |
Yep will do! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10889 +/- ##
=========================================
+ Coverage 0 91.65% +91.65%
=========================================
Files 0 405 +405
Lines 0 19031 +19031
=========================================
+ Hits 0 17442 +17442
- Misses 0 1229 +1229
- Partials 0 360 +360 ☔ View full report in Codecov by Sentry. |
Making a small fix for the depguard rule, needs a $ for the specific version. |
Signed-off-by: Erik Westra <e.s.westra.95@gmail.com>
@mx-psi Should be good to go now |
Thanks! |
Description
Migrated rand dependency to rand/v2. We only use rand in tests and mocks and the only two functions we use are float32 and float64 which still exist in the new v2 API so nothing very exciting going on here.
Link to tracking issue
Fixes #10885
Testing
Ran
make test
successfullyDocumentation