Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confmap] Remove original representation if invalid #10795

Merged
merged 8 commits into from
Aug 5, 2024
Merged

[confmap] Remove original representation if invalid #10795

merged 8 commits into from
Aug 5, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Aug 2, 2024

Description

Removes original string representation if invalid.

Link to tracking issue

Fixes #10787

Testing

Added e2e test cases

@mx-psi mx-psi mentioned this pull request Aug 2, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.70%. Comparing base (78df5c7) to head (90e52cf).

Files Patch % Lines
confmap/expand.go 60.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10795      +/-   ##
==========================================
- Coverage   91.71%   91.70%   -0.01%     
==========================================
  Files         406      406              
  Lines       18953    18947       -6     
==========================================
- Hits        17382    17376       -6     
- Misses       1211     1213       +2     
+ Partials      360      358       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi marked this pull request as ready for review August 2, 2024 11:46
@mx-psi mx-psi requested review from a team and atoulme August 2, 2024 11:46
@mx-psi mx-psi merged commit 6f27297 into open-telemetry:main Aug 5, 2024
49 of 50 checks passed
@mx-psi mx-psi deleted the mx-psi/remove-has-original branch August 5, 2024 11:07
@github-actions github-actions bot added this to the next release milestone Aug 5, 2024
@mx-psi mx-psi mentioned this pull request Aug 6, 2024
Merged
mx-psi added a commit that referenced this pull request Aug 7, 2024
@mx-psi
[chore][confmap] Show that issue 10799 is fixed (#10809)
56908c3 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Shows that #10795 (as well as #10800) fixed this issue.

#### Link to tracking issue

Fixes #10799
mx-psi added a commit that referenced this pull request Aug 20, 2024
@mx-psi
[confmap] Mark confmap.strictlyTypedInput as stable (#10793)
e477c3a 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number if applicable -->

Marks `confmap.strictlyTypedInput` as stable.

#### Link to tracking issue

Fixes #10552

Blocked by:
- #10794
- #10795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@atoulme atoulme Awaiting requested review from atoulme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging this pull request may close these issues.

Variables in comments in config files that are included are interpolated
2 participants
@mx-psi @TylerHelmuth