New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configauth] mark module stable #10646

Draft

codeboten wants to merge 3 commits into open-telemetry:main from codeboten:codeboten/stabilize-configauth

Contributor

codeboten commented Jul 17, 2024

Leaving this as draft until component/configtelemetry is sorted out

Fixes #9476


          mark module stable

36216b3

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

codecov bot commented Jul 17, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.44%. Comparing base (700aadc) to head (4540e6f).
Report is 356 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10646   +/-   ##
=======================================
  Coverage   91.43%   91.44%           
=======================================
  Files         424      424           
  Lines       20270    20270           
=======================================
+ Hits        18533    18535    +2     
+ Misses       1360     1359    -1     
+ Partials      377      376    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jpkrohling approved these changes

View reviewed changes

mx-psi reviewed

View reviewed changes

Member

mx-psi left a comment •

edited

Loading

configauth depends on extensions/auth (which depends on extensions), but this dependency is not explicit (it's an implementation detail)

IMO it's fine to make this module stable once component and configtelemetry are stable, but wanted to bring this up explicitly

Contributor

github-actions bot commented Aug 13, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

jpkrohling removed the Stale label

Contributor

github-actions bot commented Aug 28, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label


          Merge branch 'main' into codeboten/stabilize-configauth

db2868f

github-actions bot removed the Stale label

Contributor

github-actions bot commented Sep 24, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

mx-psi removed the Stale label


          Merge branch 'main' into codeboten/stabilize-configauth

4540e6f

Contributor

github-actions bot commented Oct 19, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added Stale and removed Stale labels

Contributor

github-actions bot commented Nov 4, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

jpkrohling removed the Stale label

Contributor

github-actions bot commented Nov 24, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added Stale and removed Stale labels

Contributor

github-actions bot commented Dec 9, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

jpkrohling removed the Stale label

Contributor

github-actions bot commented Dec 24, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels