-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Explicitly note that service and otelcol are not part of 1.0 #10643
[chore] Explicitly note that service and otelcol are not part of 1.0 #10643
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10643 +/- ##
==========================================
+ Coverage 92.32% 92.33% +0.01%
==========================================
Files 397 403 +6
Lines 18701 18733 +32
==========================================
+ Hits 17265 17297 +32
Misses 1076 1076
Partials 360 360 ☔ View full report in Codecov by Sentry. |
#9375 and the Collector v1 board would need an update if we merge this |
To add more context to this: the Collector 1.0 effort is focused on providing stability to end users. On the 2024-07-17 Collector Stability WG meeting we discussed the following that feels (to me at least) as a compelling argument for removing this from Collector 1.0 efforts:
A question was raised about this in how do we ensure users understand the difference. The main goal and wording we can use for Collector 1.0 stability is to say that we guarantee behavior stability of the binary, but not Go API stability. This is what other projects such as Kubernetes have successfully communicated ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These modules are useful for distribution maintainers but not end-users, for which the 1.0 effort is targeted.
Agree with otelcol
, but for service
shouldn't the configs at least be stable for end users?
I reworded to clarify that we will guarantee behavior stability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is a good estimate of the work to get I want to understand the range of options we can consider here.
|
I think the main problem is that we don't have an estimate, because this part of the API has much fewer users than the others and as such we have not really built a backlog of issues to consider here.
I expect we will continue to work on stabilizing other modules after 1.0, but I don't think this would fall in the scope of the GA roadmap. As with anything in open source, it's hard to tell 😄
I don't understand this, you mean what expectations should we set regarding when
The functionality provided at the point where we announce Collector 1.0 will continue to be supported with the same behavior until a 2.0 Collector release is done (modulo fixing bugs, which needs a judgement call)
It's hard to tell, but I think probably the answer is 'no' or at least 'not for most of it'. We have a bunch of users (vendor-backed distros, Jaeger, Agents that include OTel related functionality) of these APIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with not stabilizing the go apis for those modules as part of what we'll call 1.0. Will need to review the worked tagged with those modules to ensure that we only move issues that cover the API out of the scope of 1.0
cc @open-telemetry/collector-approvers I will merge this on Wednesday EU morning unless anybody blocks by then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering my questions. I am ok with this approach, let’s deliver everything early and come back and deliver this next.
Description
Explicitly excludes service and otelcol from 1.0 efforts.
These modules are useful for distribution maintainers but not end-users, for which the 1.0 effort is targeted.