[chore] update to mapstructure 2.0.0 #10610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
atoulme
force-pushed
the
mapstructure-2.0.0
branch
from
0c2e3da to
301dfba
Compare
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 15, 2024
**Description:** <Describe what has changed.> Relax checks on confmap validation messages to avoid running into conflicts with mapstructure upgrades See open-telemetry/opentelemetry-collector#10610 - tests don't pass with this upgrade of the mapstructure lib.
atoulme
force-pushed
the
mapstructure-2.0.0
branch
from
f74fd35 to
30d81d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10610 +/- ##
=======================================
Coverage 92.30% 92.30%
=======================================
Files 397 397
Lines 18705 18705
=======================================
Hits 17265 17265
Misses 1080 1080
Partials 360 360 ☔ View full report in Codecov by Sentry. |
evan-bradley
approved these changes
Jul 17, 2024
mx-psi
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Do we need to change
opentelemetry-collector/confmap/confmap.go
Line 181 in 43ed618
TestEmbeddedUnmarshalerError tests this and passes. We don't need to update this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reprises #10300
Testing
Fixed a few tests that no longer make sense. One test will conflict if #10609 is merged first.