Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add more e2e tests #10607

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

TylerHelmuth
Copy link
Member

Description

Adds more e2e tests to match main's current behavior. Some of these are weird, and could be used to justify #10603

Link to tracking issue

Related to #10603

@TylerHelmuth TylerHelmuth requested review from a team and mx-psi July 12, 2024 20:42
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that these are unexpected, strengthening the case for #10603

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.26%. Comparing base (6227646) to head (e289028).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10607      +/-   ##
==========================================
- Coverage   92.29%   92.26%   -0.03%     
==========================================
  Files         395      395              
  Lines       18706    18703       -3     
==========================================
- Hits        17264    17257       -7     
- Misses       1084     1086       +2     
- Partials      358      360       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi merged commit b3699f2 into open-telemetry:main Jul 15, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants