Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove vmmeter from build-and-test.yaml #10590

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Jul 10, 2024

These things were added for the arm build which has been moved to its own job.

Fixes #10587

@TylerHelmuth TylerHelmuth requested review from a team and bogdandrutu July 10, 2024 20:45
@atoulme
Copy link
Contributor

atoulme commented Jul 10, 2024

This is not just arm stuff, this provides utilization report of the runner.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (3316813) to head (304a203).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10590   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         403      403           
  Lines       18739    18739           
=======================================
  Hits        17313    17313           
  Misses       1066     1066           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TylerHelmuth
Copy link
Member Author

@atoulme where is that report going? Are we using it?

@adrielp
Copy link
Contributor

adrielp commented Jul 10, 2024

@TylerHelmuth - utilization report looks to be just text in the post step of the run which is all the action code exports as.

@atoulme - do we know the dev's over at self-actuated? I don't mean this in a negative way (seems like a cool set of projects), but it seems like a small team with low-bandwidth and a lot going on. Might be good to contribute the fix, fork, or maybe use something else?

@TylerHelmuth
Copy link
Member Author

@adrielp Thanks for pointing that out where the report lives.

My opinion is that the extra complexity of these steps is not worth the report it is generating. If we want more insight into our CI I'd rather trace our CI or advance the GitHub action receiver that @krzko proposed.

@atoulme
Copy link
Contributor

atoulme commented Jul 13, 2024

Oh I see. Let's remove it now and report to the vmeter maintainer.

@atoulme atoulme added the ready-to-merge Code review completed; ready to merge by maintainers label Jul 17, 2024
@codeboten codeboten changed the title [chore] remove arm stuff from build-and-test.yaml [chore] remove vmmeter from build-and-test.yaml Aug 2, 2024
@codeboten codeboten merged commit 685625a into open-telemetry:main Aug 2, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing due to vmeter port not found
6 participants