-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelcol] Add hint about confmap.strictlyTypedInput
feature gate
#10553
[otelcol] Add hint about confmap.strictlyTypedInput
feature gate
#10553
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10553 +/- ##
=======================================
Coverage 92.33% 92.34%
=======================================
Files 393 393
Lines 18647 18660 +13
=======================================
+ Hits 17218 17231 +13
Misses 1069 1069
Partials 360 360 ☔ View full report in Codecov by Sentry. |
Using a config similar to that of #9532 (comment) this is the error message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and detailed, I like it
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Makes type resolution strict and conforming to the behavior described in [the env vars RFC](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/env-vars.md) Depends on: - #10553 - #10555 - #10559 - open-telemetry/opentelemetry-collector-contrib/pull/33950 <!-- Issue number if applicable --> #### Link to tracking issue Fixes #9532, Fixes #8565 --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Description
Adds coda to errors related to
confmap.strictlyTypedInput
that direct users to #10552 and explain the feature gate.Link to tracking issue
Updates #9532
Testing
Tests that the coda is present when there are weakly typed errors and not present with non weakly-typed errors.