[confmap] Set confmap.unifyEnvVarExpansion feature gate to stable #10508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10508 +/- ##
==========================================
- Coverage 91.64% 91.37% -0.27%
==========================================
Files 406 406
Lines 18985 19007 +22
==========================================
- Hits 17398 17368 -30
- Misses 1227 1282 +55
+ Partials 360 357 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Making the feature gate stable negates these tests, which set the gate to false. Since the module is being deprecated, and will be removed shortly after, removing the tests doesn't feel like a big deal.
|
Let me know if you'd rather this PR and #10510 be merged into 1. If we needed to roll back for some reason 1 PR would be easier. |
|
I think we can wait at least until #10554 has been out for one release |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hi Folks - I just logged this issue it seems like there is still an issue with configurations that use "$$SomeString" syntax to represent the string literal "$SomeString" with this feature flag enabled it is still blocked on startup with version 105. |
|
@ben-childs-docusign Thanks for the report. Have you tried v0.106.1? The fix for that issue was released on v0.106.0 |
|
Hi @mx-psi yes we deployed the patch and it is working. thanks for the fix! |
mx-psi
added
the
release:blocker
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
…elmuth/opentelemetry-collector into unify-env-var-gate-stable
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
|
I am going to wait to merge this until #10510 is approved |
#### Description This PR deprecates `expandconverter` and removes its use from `otelcoltest.LoadConfig` and OCB. This cannot be merged until the `confmap.unifyEnvVarExpansion` [feature gate is made stable](#10508). <!-- Issue number if applicable --> #### Link to tracking issue closes #10161 closes #7111 closes #8215 --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Description
This PR promotes the
confmap.unifyEnvVarExpansionfeature gate to stable and sets aToVersionofv0.106.0, anticipating that the gate be completely removed in that version.We should weigh if switching the Stable should be done in
v0.105.0or if it needs more time inBetato give users more time to switch. Delaying promotion toStabledelays confmap 1.0.If we merge this we need to commit to merging #10510 in the same release.
Link to tracking issue
Related to #10161
Related to #7111
Related to #8215