Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exporterhelper): Add concurrency sender to send batches concurrently #10478

Closed
Closed
Prev Previous commit
Next Next commit
revert batchprocessor
  • Loading branch information
moh-osman3 committed Aug 5, 2024
commit bb586d63e74e54926c3b6e61e512a7a0f928cd86
3 changes: 0 additions & 3 deletions processor/batchprocessor/batch_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -258,15 +258,12 @@ func (b *shard) resetTimer() {
}

func (b *shard) sendItems(trigger trigger) {
go func() {

sent, bytes, err := b.batch.export(b.exportCtx, b.processor.sendBatchMaxSize, b.processor.telemetry.detailed)
if err != nil {
b.processor.logger.Warn("Sender failed", zap.Error(err))
} else {
b.processor.telemetry.record(trigger, int64(sent), int64(bytes))
}
}()
}

// singleShardBatcher is used when metadataKeys is empty, to avoid the
Expand Down