Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OTLP/HTTP X-Protobuf Receiver #1021

Merged
merged 3 commits into from
May 26, 2020

Commits on May 22, 2020

  1. Implement OTLP/HTTP X-Protobuf Receiver

    This change adds application/x-protobuf support to the existing
    grpc-gateway mux in the OTLP receiver.
    
    See: https://github.com/open-telemetry/oteps/blob/master/text/0099-otlp-http.md
    
    What currently works:
    * The receiver will correctly process HTTP requests with the
      Content-Type application/x-protobuf.
    * The receiver will respond with Content-Type application/x-protobuf.
    * The receiver will respond with status code HTTP 200 OK on success.
    What doesn't work yet:
    * The receiver cannot handle gzip-encoded requests (Content-Encoding
      gzip).
    * The receiver will not gzip-encode responses to requests with
      Accept-Encoding: gzip.
    
    
    Updates open-telemetry#881
    kirbyquerby committed May 22, 2020
    Configuration menu
    Copy the full SHA
    054b75f View commit details
    Browse the repository at this point in the history
  2. use embedding to avoid unnecessary duplicate code

    runtime.ProtoMarshaller is now embedded in xProtoBufMarshaler so that only ContentType() needs to be implemented.
    kirbyquerby committed May 22, 2020
    Configuration menu
    Copy the full SHA
    622783f View commit details
    Browse the repository at this point in the history

Commits on May 26, 2020

  1. Configuration menu
    Copy the full SHA
    d3065a9 View commit details
    Browse the repository at this point in the history