Unify log message when exporter or receiver is not registered #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
requested review from
bogdandrutu,
dmitryax,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
pavolloffay
commented
May 25, 2020
| @@ -232,11 +232,7 @@ func (eb *ExportersBuilder) buildExporter( | |||
|
|
|||
| inputDataTypes := exportersInputDataTypes[config] | |||
| if inputDataTypes == nil { | |||
| // TODO https://go.opentelemetry.io/collector/issues/294 | |||
| // Move this validation to config/config.go:validateConfig | |||
There was a problem hiding this comment.
The validation is not needed. In Jaeger we rely on the behavior that does not require registering all rec/exp to the pipeline.
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 85.61% 85.63% +0.01%
==========================================
Files 189 189
Lines 13167 13167
==========================================
+ Hits 11273 11275 +2
+ Misses 1441 1440 -1
+ Partials 453 452 -1
Continue to review full report at Codecov.
|
|
can somebody restart the |
dmitryax
approved these changes
May 25, 2020
wyTrivail
pushed a commit
to mxiamxia/opentelemetry-collector
that referenced
this pull request
Jul 13, 2020
…elemetry#1018) Resolves: jaegertracing/jaeger#2252 Related to open-telemetry#294 Just fixing the log message. The warn level was printing stacktrace what was confusing for users.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: jaegertracing/jaeger#2252
Related to #294
Description:
Just fixing the log message. The warn level was printing stacktrace what was confusing for users.
Link to tracking Issue:
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>