Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdatagen] move telemetry into its own file #10037

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[mdatagen] move telemetry into its own file #10037

merged 3 commits into from
Apr 29, 2024

Conversation

codeboten
Copy link
Contributor

This is in preparation for using mdatagen for component telemetry.

@codeboten
[mdatagen] move telemetry into its own file
9b87aa7 
This is in preparation for using mdatagen for component telemetry.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 26, 2024
@codeboten codeboten requested review from a team and bogdandrutu April 26, 2024 21:15
@codecov Codecov
Copy link

codecov bot commented Apr 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.54839% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 91.87%. Comparing base (326ef7c) to head (4c38412).
Report is 3 commits behind head on main.

Files Patch % Lines
cmd/mdatagen/main.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10037      +/-   ##
==========================================
+ Coverage   91.55%   91.87%   +0.31%     
==========================================
  Files         360      360              
  Lines       16693    16725      +32     
==========================================
+ Hits        15284    15366      +82     
+ Misses       1073     1021      -52     
- Partials      336      338       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten
gogenerate
13b3ff9 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
add generated_telemetry_test
4c38412 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
evan-bradley
evan-bradley approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the generated tests. Those have been a bit of a sore point when adding new components.

@codeboten codeboten merged commit ce09d97 into open-telemetry:main Apr 29, 2024
47 of 48 checks passed
@codeboten codeboten deleted the codeboten/mdatagen-internal-telemetry branch April 29, 2024 19:12
@github-actions github-actions bot added this to the next release milestone Apr 29, 2024
andrzej-stencel pushed a commit to andrzej-stencel/opentelemetry-collector that referenced this pull request May 27, 2024
@codeboten @andrzej-stencel
[mdatagen] move telemetry into its own file (open-telemetry#10037)
34564ad 
This is in preparation for using mdatagen for component telemetry.

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@evan-bradley evan-bradley evan-bradley approved these changes

@songy23 songy23 songy23 approved these changes

@dmitryax dmitryax dmitryax approved these changes

@mx-psi mx-psi mx-psi approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.100.0
Development

Successfully merging this pull request may close these issues.
6 participants
@codeboten @mx-psi @dmitryax @songy23 @evan-bradley @TylerHelmuth