Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/builder] Improve TestVersioning #10000

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Apr 19, 2024

Description

Improves TestVersioning added on #9897.

The configurations were not what one would usually find, since when running the builder we do some validation and setup.
This makes it closer to the real case.

In the process I removed the 'invalid' cases, since these error out today already

@mx-psi mx-psi requested review from kristinapathak, a team and songy23 April 19, 2024 11:46
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 19, 2024
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I made some similar changes in #9513. Congrats on claiming #10000.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.68%. Comparing base (dc48d0e) to head (456ae08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10000      +/-   ##
==========================================
- Coverage   91.77%   91.68%   -0.10%     
==========================================
  Files         360      360              
  Lines       16635    16635              
==========================================
- Hits        15267    15251      -16     
- Misses       1041     1051      +10     
- Partials      327      333       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi
Copy link
Member Author

mx-psi commented Apr 19, 2024

Looks good to me, I made some similar changes in #9513. Congrats on claiming #10000.

Thank you! 😄 🚀 🎉

@mx-psi mx-psi merged commit 0aa9b10 into open-telemetry:main Apr 19, 2024
65 of 66 checks passed
@mx-psi mx-psi deleted the mx-psi/more-realistic-builder-tests branch April 19, 2024 15:04
@github-actions github-actions bot added this to the next release milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants