Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create common scraping library #934

Closed
jrcamp opened this issue May 8, 2020 · 1 comment · Fixed by #1886
Closed

Create common scraping library #934

jrcamp opened this issue May 8, 2020 · 1 comment · Fixed by #1886
Labels
enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone

Comments

@jrcamp
Copy link
Contributor

jrcamp commented May 8, 2020

Many of the new receivers being created (host metrics, redis, kubelet-stats, etc.) are all scrape based. They each collect metrics on a periodic interval and have other common needs like enabling/disabling individual metrics.

@james-bebbington @asuresh4 @pmcollins @bogdandrutu

@pmcollins
Copy link
Member

@bogdandrutu 's suggestion in slack:

we can start with something easy:
I think we can have a "configmodels.MetricsScraper extends configmodels.Receiver" config that includes a "scrape_interval" and it comes with a reasonable default.
Then we can make a change to allow flag or env variable to configure that default

@flands flands added the enhancement New feature or request label May 13, 2020
@bogdandrutu bogdandrutu added this to the Backlog milestone Aug 4, 2020
@bogdandrutu bogdandrutu added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Aug 4, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
Also, update the releasing docs to match new command and clean up new
structure.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
* add replicas support

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* note about replicas setting for postgres, kafka, and redis

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
4 participants