Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split each receiver/* on its own module #6190

Closed
Tracked by #5992
jpkrohling opened this issue Sep 29, 2022 · 0 comments · Fixed by #6425
Closed
Tracked by #5992

Split each receiver/* on its own module #6190

jpkrohling opened this issue Sep 29, 2022 · 0 comments · Fixed by #6425
Assignees
@codeboten

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Sep 29, 2022 •
edited
Loading

From @bogdandrutu:

The current "scraperrelated packages I would move them into ascraper/` top directory and package.
@jpkrohling jpkrohling mentioned this issue Sep 29, 2022
Closed
11 tasks
@jpkrohling jpkrohling changed the title receiver/* in each individual package. The current "scraperrelated packages I would move them into ascraper/` top directory and package. Split each receiver/* on its own module Sep 29, 2022
@codeboten codeboten self-assigned this Oct 27, 2022
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Oct 27, 2022
split receiver/otlpreceiver into its own module
88fa6ea 
This splits the OTLP receiver into its own module. Currently this leaves `scraperhelper` and `scrapererror` inside the main collector module, this is similar to `exporterhelper`. Note that doing this split brought up the interesting issue that the OTLP HTTP exporter depends on the OTLP receiver for some of its tests. I can address this separately from this PR.

Fixes open-telemetry#6190
@codeboten codeboten mentioned this issue Oct 27, 2022
Merged
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Oct 31, 2022
split receiver/otlpreceiver into its own module
95f89b4 
This splits the OTLP receiver into its own module. Currently this leaves `scraperhelper` and `scrapererror` inside the main collector module, this is similar to `exporterhelper`. Note that doing this split brought up the interesting issue that the OTLP HTTP exporter depends on the OTLP receiver for some of its tests. I can address this separately from this PR.

Fixes open-telemetry#6190
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Nov 1, 2022
split receiver/otlpreceiver into its own module
e059e77 
This splits the OTLP receiver into its own module. Currently this leaves `scraperhelper` and `scrapererror` inside the main collector module, this is similar to `exporterhelper`. Note that doing this split brought up the interesting issue that the OTLP HTTP exporter depends on the OTLP receiver for some of its tests. I can address this separately from this PR.

Fixes open-telemetry#6190
codeboten pushed a commit that referenced this issue Nov 1, 2022
split receiver/otlpreceiver into its own module (#6425)
df8deb4 
This splits the OTLP receiver into its own module. Currently this leaves `scraperhelper` and `scrapererror` inside the main collector module, this is similar to `exporterhelper`. Note that doing this split brought up the interesting issue that the OTLP HTTP exporter depends on the OTLP receiver for some of its tests. I can address this separately from this PR.

Fixes #6190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

split receiver/otlpreceiver into its own module codeboten/opentelemetry-collector
2 participants
@jpkrohling @codeboten