-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocb Docker image #5712
Comments
@dmitryax @jpkrohling As far as I could understand, we want to create a Dockerfile & release docker images for the collector builder, can I work on this if this is still relevant? |
Sure, I think it would be worth the exercise. I'm not convinced this would work seamlessly for some Linux distributions (like Fedora), as selinux would prevent containers from writing to the host's file system, but I might be wrong. |
@jpkrohling that should work using the |
I see that we have docker images for the official releases, but I'm thinking it might still be useful to have docker images for custom builds. |
After discussion with the collector SIG call this week, July 31st, I have made small tweaks to the artifact release that will not require an "extra step" of pushing tags. If these changes are accepted, the distributions will be released under tag "vX.XXX.X" and the ocb binaries will be released under "cmd/builder/vX.XXX.X" but both under this repo, opentelemetry-collector-releases. The workflow `builder-release.yaml` in releases repo will push the additional tags necessary for the builder release. Refactoring the release process as mentioned in past issues/PRs. ocb binary is currently released in a separate release tag under this repository, which makes it harder to find and inconsistent with the rest of the binaries and images releasing in the opentelemetry-collector-releases repository. Releasing the ocb binaries in opentelemetry-collector-releases makes this process more standardized and also opens the opportunity to release more tools alongside ocb binary down the road, like corresponding docker images (as discussed in #5712). #### Link to tracking issue Fixes #10662 Mentioned in [releases issue # 295](open-telemetry/opentelemetry-collector-releases#295) [Corresponding PR in opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#608) #### Testing Sample binary release in [forked jackgopack4/opentelemetry-collector-releases repo](https://github.com/jackgopack4/opentelemetry-collector-releases/releases/tag/cmd%2Fbuilder%2Fv0.106.1) #### Documentation Updated corresponding documentation to reflect new release process --------- Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Hi there, i'd like to create another repository under the "otel" organization on DockerHub, I believe it could be called "otel/opentelemetry-collector-builder" or "otel/ocb"; who has the ability to create this? thanks. |
@jackgopack4 I'd guess this would be done through an issue in the community repository but we should discuss what name we want first. |
PRs are up: |
Is your feature request related to a problem? Please describe.
Per open-telemetry/opentelemetry-collector-releases/pull/164, we want to promote usage of the OpenTelemetry Collector Builder so that people build their own distribution with only the components they use.
We currently only provide the binaries on each release (example), but we don't have a Docker image for this, which would ease the use of the builder.
Describe the solution you'd like
Provider a Docker image for the builder.
Describe alternatives you've considered
Do nothing, if we consider this is not going to get usage.
The text was updated successfully, but these errors were encountered: