Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Registry Support #3022

Closed
sincejune opened this issue Apr 26, 2021 · 6 comments
Closed

Proposal: Registry Support #3022

sincejune opened this issue Apr 26, 2021 · 6 comments

Comments

@sincejune
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Opentelemetry-Collector can either be pull-based or push-based at this time.
For receivers that are pull-based (e.g. kafka and filelog receivers), we actually need a registry file for them so that Opentelemetry-Collector can continue consuming data from the last stop.

@pmm-sumo
Copy link
Contributor

pmm-sumo commented Apr 26, 2021

This capability is in progress for filelog receiver. Perhaps it could be generalised @djaglowski ? Related issue: open-telemetry/opentelemetry-collector-contrib#2947

@djaglowski
Copy link
Member

Yes, filelogreceiver will make use of a file_storage extension, if configured as part of the service.

Any other component of the collector can do the same. You will need to enhance the component's Start method to check for a storage extension, and then make use of it. Here is where filelogreceiver checks for a storage extension.

@sincejune
Copy link
Contributor Author

sincejune commented May 5, 2021

@djaglowski It looks great!
I can try to make a contribution to Kafka Receiver. But it looks like we need to move the storage definition into this repo as the first step. Thoughts?

@djaglowski
Copy link
Member

@sincejune That is a good point. I believe there is a good chance the storage extension code may end up in this repo, but this will be up to the maintainers to decide. //cc @tigrannajaryan

@tigrannajaryan
Copy link
Member

@sincejune That is a good point. I believe there is a good chance the storage extension code may end up in this repo, but this will be up to the maintainers to decide. //cc @tigrannajaryan

Let's give a bit time for storage extension to be polished and stabilized in the contrib and then we will move it to this repo. It should like happen after the GA to avoid delaying the GA further.

@sincejune
Copy link
Contributor Author

I just realized that Kafka had already stored offset information itself so we don't have to add supports particularly for that.
Closing this as we already have filestorage.

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants