Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch processor returns a bigger batch than configured #1140

Closed
pavolloffay opened this issue Jun 18, 2020 · 0 comments · Fixed by #1310
Closed

Batch processor returns a bigger batch than configured #1140

pavolloffay opened this issue Jun 18, 2020 · 0 comments · Fixed by #1310
Labels
bug Something isn't working
Milestone
Beta 0.6.0

Comments

@pavolloffay
Copy link
Member

pavolloffay commented Jun 18, 2020 •
edited
Loading

Describe the bug

The Batch processor can send a bigger batch than it is configured. For example send_batch_size is sed to 500 but the returned batches are ~800.

Steps to reproduce
Configure send_batch_size = N and send either bigger batches to the receiver or smaller but in very high frequency.

What did you expect to see?

The returned batch size always be <= configured size in send_batch_size.

What did you see instead?

Batch sizes >= send_batch_size.

What version did you use?
master

What config did you use?

processors:
  batch:
    send_batch_size: 1000
    timeout: 200ms

Environment
Linux

Additional context
Add any other context about the problem here.
@pavolloffay pavolloffay added the bug Something isn't working label Jun 18, 2020
@pavolloffay pavolloffay mentioned this issue Jun 18, 2020
Merged
3 tasks
@flands flands added this to the GA 1.0 milestone Jun 18, 2020
@pavolloffay pavolloffay mentioned this issue Jul 9, 2020
Merged
@bogdandrutu bogdandrutu mentioned this issue Jul 13, 2020
Closed
@flands flands modified the milestones: GA 1.0, Beta 0.6.0 Jul 16, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@rakyll
Document make test for testing (open-telemetry#1154)
4c5f834 
Fixes open-telemetry#1140
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@rmfitzpatrick
update env var expansion test with non env var usage (open-telemetry#…
674a877 
…1140)
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@lalitb
sem ver (open-telemetry#1140)
4f5505f
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@dependabot
Bump azure/setup-helm from 3.5 to 4 (open-telemetry#1140)
712dbd5 
Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 3.5 to 4.
- [Release notes](https://github.com/azure/setup-helm/releases)
- [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md)
- [Commits](Azure/setup-helm@v3.5...v4)

---
updated-dependencies:
- dependency-name: azure/setup-helm
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Beta 0.6.0
Development

Successfully merging a pull request may close this issue.

Fix overflowing batch size pavolloffay/opentelemetry-collector
2 participants
@flands @pavolloffay