Remove deprecated function IsValid from trace/span ID (#2522)

Updates #2488 Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
open-telemetry · Feb 22, 2021 · d71dd31 · d71dd31
1 parent 347cfa9
commit d71dd31
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 🛑 Breaking changes 🛑
+
+- Remove deprecated function `IsValid` from trace/span ID (#2522)
+
 ## v0.20.0 Beta
 
 ## 🛑 Breaking changes 🛑

diff --git a/consumer/pdata/spanid.go b/consumer/pdata/spanid.go
@@ -39,12 +39,6 @@ func (t SpanID) HexString() string {
 	return data.SpanID(t).HexString()
 }
 
-// IsValid returns true if id contains at leas one non-zero byte.
-// Deprecated: use !IsEmpty() instead.
-func (t SpanID) IsValid() bool {
-	return !data.SpanID(t).IsEmpty()
-}
-
 // IsEmpty returns true if id doesn't contain at least one non-zero byte.
 func (t SpanID) IsEmpty() bool {
 	return data.SpanID(t).IsEmpty()

diff --git a/consumer/pdata/traceid.go b/consumer/pdata/traceid.go
@@ -39,12 +39,6 @@ func (t TraceID) HexString() string {
 	return data.TraceID(t).HexString()
 }
 
-// IsValid returns true if id contains at leas one non-zero byte.
-// Deprecated: use !IsEmpty() instead.
-func (t TraceID) IsValid() bool {
-	return !data.TraceID(t).IsEmpty()
-}
-
 // IsEmpty returns true if id doesn't contain at least one non-zero byte.
 func (t TraceID) IsEmpty() bool {
 	return data.TraceID(t).IsEmpty()