[pdata] Update return value of pcommon.ValueType.String for ValueTypeStr

Recently we updated all names related to pdata String value. It makes sense to update string returned by Value.String accordingly to avoid discrepancy with other value types
open-telemetry · Oct 6, 2022 · 904f844 · 904f844
1 parent e0eea95
commit 904f844
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@
 - Delete deprecated `StringVal` and `SetStringVal` methods. (#6178)
 - Delete deprecated `ValueTypeString` method. (#6178)
 - Change AggregationTemporality.String to simpler, easier to read. (#6117)
+- Update pcommon.ValueType.String to return "STR" for ValueTypeStr. (#6127)
 
 ### 🚩 Deprecations 🚩
 

diff --git a/pdata/pcommon/common.go b/pdata/pcommon/common.go
@@ -50,7 +50,7 @@ func (avt ValueType) String() string {
 	case ValueTypeEmpty:
 		return "EMPTY"
 	case ValueTypeStr:
-		return "STRING"
+		return "STR"
 	case ValueTypeBool:
 		return "BOOL"
 	case ValueTypeInt:

diff --git a/pdata/pcommon/common_test.go b/pdata/pcommon/common_test.go
@@ -58,7 +58,7 @@ func TestValue(t *testing.T) {
 
 func TestValueType(t *testing.T) {
 	assert.EqualValues(t, "EMPTY", ValueTypeEmpty.String())
-	assert.EqualValues(t, "STRING", ValueTypeStr.String())
+	assert.EqualValues(t, "STR", ValueTypeStr.String())
 	assert.EqualValues(t, "BOOL", ValueTypeBool.String())
 	assert.EqualValues(t, "INT", ValueTypeInt.String())
 	assert.EqualValues(t, "DOUBLE", ValueTypeDouble.String())