allow empty featuregate values

open-telemetry · Jul 10, 2022 · 8632ba6 · 8632ba6
1 parent 58e66af
commit 8632ba6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/service/featuregate/flags.go b/service/featuregate/flags.go
@@ -44,6 +44,10 @@ func (f FlagValue) String() string {
 
 // Set applies the FlagValue encoded in the input string
 func (f FlagValue) Set(s string) error {
+	if s == "" {
+		return nil
+	}
+
 	return f.setSlice(strings.Split(s, ","))
 }
 

diff --git a/service/featuregate/flags_test.go b/service/featuregate/flags_test.go
@@ -27,6 +27,11 @@ func TestFlagValue_basic(t *testing.T) {
 		output     FlagValue
 		skipString bool
 	}{
+		{
+			name:   "empty item",
+			input:  "",
+			output: FlagValue{},
+		},
 		{
 			name:   "single item",
 			input:  "foo",