Making access atomic to the collector's level (#4549)

* Making access atomic to the collector's level

In order to allow for more tests to run concurrently without triggering
the race detector, Level needs to be guarded by some atomic method.
This change makes access to the collector's Level managable via sync
method which may lead to eventual consistent.

* Update obsreport/obsreport_test.go

Remove this change

config/configtelemetry/configtelemetry.go

@@ -53,7 +53,7 @@ func Flags(flags *flag.FlagSet) {
 
 // Level is the level of internal telemetry (metrics, logs, traces about the component itself)
 // that every component should generate.
-type Level int8
+type Level int32
 
 var _ flag.Value = (*Level)(nil)
 

internal/obsreportconfig/obsreportconfig.go

@@ -15,6 +15,8 @@
 package obsreportconfig // import "go.opentelemetry.io/collector/internal/obsreportconfig"
 
 import (
+	"sync/atomic"
+
 	"go.opencensus.io/stats"
 	"go.opencensus.io/stats/view"
 	"go.opencensus.io/tag"
@@ -24,7 +26,7 @@ import (
 )
 
 var (
-	Level = configtelemetry.LevelBasic
+	globalLevel = int32(configtelemetry.LevelBasic)
 )
 
 // ObsMetrics wraps OpenCensus View for Collector observability metrics
@@ -35,10 +37,11 @@ type ObsMetrics struct {
 // Configure is used to control the settings that will be used by the obsreport
 // package.
 func Configure(level configtelemetry.Level) *ObsMetrics {
-	Level = level
+	atomic.StoreInt32(&globalLevel, int32(level))
+
 	var views []*view.View
 
-	if Level != configtelemetry.LevelNone {
+	if Level() != configtelemetry.LevelNone {
 		obsMetricViews := allViews()
 		views = append(views, obsMetricViews.Views...)
 	}
@@ -48,6 +51,10 @@ func Configure(level configtelemetry.Level) *ObsMetrics {
 	}
 }
 
+func Level() configtelemetry.Level {
+	return configtelemetry.Level(atomic.LoadInt32(&globalLevel))
+}
+
 // allViews return the list of all views that needs to be configured.
 func allViews() *ObsMetrics {
 	var views []*view.View

obsreport/obsreport_exporter.go

@@ -106,7 +106,7 @@ func (exp *Exporter) startOp(ctx context.Context, operationSuffix string) contex
 }
 
 func (exp *Exporter) recordMetrics(ctx context.Context, numSent, numFailedToSend int64, sentMeasure, failedToSendMeasure *stats.Int64Measure) {
-	if obsreportconfig.Level == configtelemetry.LevelNone {
+	if obsreportconfig.Level() == configtelemetry.LevelNone {
 		return
 	}
 	// Ignore the error for now. This should not happen.

obsreport/obsreport_receiver.go

@@ -161,7 +161,7 @@ func (rec *Receiver) endOp(
 
 	span := trace.SpanFromContext(receiverCtx)
 
-	if obsreportconfig.Level != configtelemetry.LevelNone {
+	if obsreportconfig.Level() != configtelemetry.LevelNone {
 		var acceptedMeasure, refusedMeasure *stats.Int64Measure
 		switch dataType {
 		case config.TracesDataType:

obsreport/obsreport_scraper.go

@@ -87,7 +87,7 @@ func (s *Scraper) EndMetricsOp(
 
 	span := trace.SpanFromContext(scraperCtx)
 
-	if obsreportconfig.Level != configtelemetry.LevelNone {
+	if obsreportconfig.Level() != configtelemetry.LevelNone {
 		stats.Record(
 			scraperCtx,
 			obsmetrics.ScraperScrapedMetricPoints.M(int64(numScrapedMetrics)),