Skip to content

Commit

Permalink
review PR
Browse files Browse the repository at this point in the history
  • Loading branch information
antonjim-te committed Sep 11, 2023
1 parent 8a321ac commit 0cb309c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion .chloggen/SampledLoggerTelemetry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ issues: [8134]
# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: The sampled logger is built from the logger. It is built using default config (sample 100 logs in a second after 10 initial logs)
subtext: The sampled logger is built from the logger. It is configured sampling 100 logs in a second after 10 initial logs)


# Optional: The change log or logs in which this entry should be included.
Expand Down
1 change: 0 additions & 1 deletion service/telemetry/telemetry.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ func New(_ context.Context, set Settings, cfg Config) (*Telemetry, error) {
if err != nil {
return nil, err
}

tp := sdktrace.NewTracerProvider(
// needed for supporting the zpages extension
sdktrace.WithSampler(alwaysRecord()),
Expand Down

0 comments on commit 0cb309c

Please sign in to comment.