-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testbed] disable setting grpc log #9564
[testbed] disable setting grpc log #9564
Conversation
@codeboten please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bogdandrutu done
This is causing a race condition with the InProcessCollector.
0e9a760
to
5f3aff3
Compare
=== RUN TestMetricGroupData_toDistributionUnitTest/histogram_with_startTimestamp_of_11
otlp_metricfamily_test.go:181:
Error Trace: otlp_metricfamily_test.go:181
Error: Not equal:
expected: internal.HistogramDataPoint{orig:(*v1.HistogramDataPoint)(0xc00012e360)}
actual : internal.HistogramDataPoint{orig:(*v1.HistogramDataPoint)(0xc00012e2d0)}
Diff:
--- Expected
+++ Actual
@@ -29,4 +29,3 @@
},
- ExplicitBounds: ([]float64) {
- },
+ ExplicitBounds: ([]float64) <nil>,
Exemplars: ([]v1.Exemplar) <nil>,
Test: TestMetricGroupData_toDistributionUnitTest/histogram_with_startTimestamp_of_11
Messages: Expected the points to be equal
=== RUN TestMetricGroupData_toDistributionUnitTest/histogram_that_is_stale
otlp_metricfamily_test.go:181:
Error Trace: otlp_metricfamily_test.go:181
Error: Not equal:
expected: internal.HistogramDataPoint{orig:(*v1.HistogramDataPoint)(0xc0003f3290)}
actual : internal.HistogramDataPoint{orig:(*v1.HistogramDataPoint)(0xc0003f3200)}
Diff:
--- Expected
+++ Actual
@@ -27,4 +27,3 @@
},
- ExplicitBounds: ([]float64) {
- },
+ ExplicitBounds: ([]float64) <nil>,
Exemplars: ([]v1.Exemplar) <nil>,
Test: TestMetricGroupData_toDistributionUnitTest/histogram_that_is_stale
Messages: Expected the points to be equal This error is caused by a change in |
@codeboten @bogdandrutu do you think we can update the test to change original slices to nil? Otherwise I can also update the CopyTo to make exact copy of slices |
@dmitryax I updated the test |
…-telemetry#9564) This change includes: - set the flag to disable setting the grpc logger from the `InProcessCollector` - `make update-otel` - update calls to `featuregate` as a result of open-telemetry/opentelemetry-collector@addf0ef - update tests as a result of open-telemetry/opentelemetry-collector@5658f35
This is causing a race condition with the InProcessCollector.
This change includes:
InProcessCollector
make update-otel
featuregate
as a result of open-telemetry/opentelemetry-collector@addf0efFixes #9557