-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Check contrib modules are using the correct core collector version #9112
[ci] Check contrib modules are using the correct core collector version #9112
Conversation
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
e9b2647
to
9482dc2
Compare
Review: - open-telemetry#9112 (review) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Thanks for the review @mx-psi. dated and ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, seems to work fine. I would like another approver/maintainer to take a look before I mark as ready to merge
And thanks for doing this @hickeyma 🙇 I think this will make releases a bit smoother |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of minor comments. Would you be able to add example outputs as a comment to this PR?
Review: - open-telemetry#9112 (review) Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
Thanks for the review and feedback @jpkrohling. I have updated with your comments. It is ready for review again.
I added output to the description. |
Description from @mx-psi in #8546 (comment):
The result of check-collector-module-version (no incorrect versions):
The result of check-collector-module-version (incorrect versions):
The result of check-collector-module-version (incorrect model versions):
Fixes #8546
Signed-off-by: Martin Hickey martin.hickey@ie.ibm.com