Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Check contrib modules are using the correct core collector version #9112

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

hickeyma
Copy link
Contributor

@hickeyma hickeyma commented Apr 7, 2022

Description from @mx-psi in #8546 (comment):

My intention is to avoid the following situation:

  1. Someone creates a PR adding a new examplemodule module, targeting Collector core vN module
  2. Weeks pass, it gets reviewed and merged just before the vN+3 contrib release, still targeting vN
  3. The release manager for vN+3 has then to manually update the examplemodule module code to be compatible with vN+3

I want to avoid (3) and, instead, make the contributor adding examplemodule do that job before merging the PR, by comparing the Collector core version at the top-level go.mod file with the Collector core version at the examplemodule go.mod file.

The result of check-collector-module-version (no incorrect versions):

There are 0 incorrect "go.opentelemetry.io/collector " version(s) in the module files.
There are 0 incorrect "go.opentelemetry.io/collector/model" version(s) in the module files.

The result of check-collector-module-version (incorrect versions):

Incorrect version "v0.47.0" of "go.opentelemetry.io/collector " is included in "./receiver/couchbasereceiver/go.mod". It should be version "v0.48.0".
Incorrect version "v0.44.0" of "go.opentelemetry.io/collector " is included in "./exporter/awsemfexporter/go.mod". It should be version "v0.48.0".
There are 2 incorrect "go.opentelemetry.io/collector " version(s) in the module files.

The result of check-collector-module-version (incorrect model versions):

There are 0 incorrect "go.opentelemetry.io/collector " version(s) in the module files.
Incorrect version "v0.43.0" of "go.opentelemetry.io/collector/model" is included in "./exporter/datadogexporter/go.mod". It should be version "v0.48.0".
There are 1 incorrect "go.opentelemetry.io/collector/model" version(s) in the module files.

Fixes #8546

Signed-off-by: Martin Hickey martin.hickey@ie.ibm.com

@hickeyma hickeyma requested review from a team and mx-psi April 7, 2022 11:40
@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 7, 2022
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma hickeyma force-pushed the ci/check-coll-mod-vers branch from e9b2647 to 9482dc2 Compare April 8, 2022 08:11
Review:
- open-telemetry#9112 (review)

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma
Copy link
Contributor Author

hickeyma commented Apr 8, 2022

Thanks for the review @mx-psi. dated and ready for review again.

@hickeyma hickeyma requested a review from mx-psi April 8, 2022 08:57
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, seems to work fine. I would like another approver/maintainer to take a look before I mark as ready to merge

@mx-psi
Copy link
Member

mx-psi commented Apr 8, 2022

And thanks for doing this @hickeyma 🙇 I think this will make releases a bit smoother

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of minor comments. Would you be able to add example outputs as a comment to this PR?

Review:
- open-telemetry#9112 (review)

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma
Copy link
Contributor Author

hickeyma commented Apr 8, 2022

Thanks for the review and feedback @jpkrohling. I have updated with your comments. It is ready for review again.

Would you be able to add example outputs as a comment to this PR?

I added output to the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Check consistent version usage of core collector dependencies
4 participants