fix lint build failures #7170
Merged
fix lint build failures #7170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
reviewed
Jan 14, 2022
| @@ -75,7 +75,7 @@ jobs: | |||
| path: /home/runner/.cache/go-build | |||
| key: go-build-lint-${{ runner.os }}-${{ hashFiles('**/go.mod', '**/go.sum') }} | |||
| - name: Lint | |||
| run: make -j4 golint | |||
| run: make -j2 golint | |||
There was a problem hiding this comment.
Wouldn't it be better to increase the timeout itself as well?
There was a problem hiding this comment.
🤔 hmmm the timeout for golangci-lint is already set to 10m:
There was a problem hiding this comment.
I suspect that something wrong is happening after this PR #7153
I see that at least nvm, this is incorrect assumptionmisspell is running multiple times in every package because it validates all the nested files in each module
dmitryax
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the number of parallel linters appears to be causing timeouts in the lint job.
Fixes #7169