[exporter/datadogexporter] Always add current hostname #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
approved these changes
Oct 28, 2021
mx-psi
added
the
ready to merge
bogdandrutu
approved these changes
Nov 2, 2021
mx-psi
added a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Dec 9, 2021
jpkrohling
pushed a commit
that referenced
this pull request
Dec 21, 2021
#6670) * [exporter/datadogexporter] Make hostname empty on AWS ECS Fargate * Revert "[exporter/datadog] Always add current hostname (#5967)" This reverts commit 247420a. We can't always add the current hostname *and* not expose the hostname in Fargate. * [exporter/datadogexporter] Add `task_arn` instead of a hostname for running metrics We do this because of two reasons: 1. we don't want to expose the Fargate hostname and 2. users care about identifying where their Collector is running (in this case which task). * Address review comment * Add changelog note
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Always add current host hostname to the running metrics.
This is helpful in multi Collector setups, where, until now, the 'last' Collector was ignored.