-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support of Bearer Auth for HTTP Exporters #5962
Added support of Bearer Auth for HTTP Exporters #5962
Conversation
@jpkrohling @anuraaga please review - thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I just realized we don't have support for auth in the confighttp struct like we have for configgrpc, so, we cannot have an HTTP receiver that requires auth.
Thanks @jpkrohling - shall I open an issue to handle receivers as well for consistency or we don't want to tackle it? This pr brings consistency on exporters side though. BTW, not sure what's happening with k8cluster unit test |
Created #5973 to track the test failure on unrelated code, and tests restarted. |
Another unrelated test failure. Created #5983, tests restarted. |
Thank you - Looks like tests are fine now. |
I don't seem to have merge powers yet, but this is ready to be merged. |
@jpkrohling fixed the power 👯 |
Current implementation for Bearer token auth only supports gRPC clients. This implementation enables the functionality for HTTP clients as well.
Link to tracking Issue: #5927
Testing: : Unit tests and verfied on the mock server Auth headers were set properly.
Documentation: Updated README.md with new path as well.