allow to replace job label #5882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return &mCache{target}, nil | ||
| for _, targets := range s.sm.TargetsAll() { | ||
| for _, target := range targets { | ||
| if target.Labels().Get(model.JobLabel) == job && target.Labels().Get(model.InstanceLabel) == instance { |
There was a problem hiding this comment.
@GlowingRuby - Thanks for making this PR. I have a couple of questions.
- This will help with the relabel_config but might not solve the metric_relabel_config problem, since the metrics being passed have new labels that is not available in the target list.
- At a very high scale, this lookup may be expensive.
I am curious to hear your thoughts about this.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix #5663
Testing: Test_transaction