-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify health check extension to add new metrics health check functions #5643
Conversation
Tests started. |
@skyduo please address this lint failure (and any others reported by running
|
a90c340
to
9580147
Compare
not sure why |
dc351aa
to
c116c19
Compare
hi @bogdandrutu ! could you help check and approve this pr if possible? Anthony and Juraci has approved, just wait for your final approval. |
Hey @bogdandrutu, since this pr is ready to merge, could you help approve it? Thanks! |
Hi @bogdandrutu gentle reminder for a final review and merge from you for this PR. We would like to be able to make this feature available for OTEL users in the next release. Ty in advance! |
ba619c0
to
7c4e913
Compare
hi @bogdandrutu! i just resolve all the issues and merge it to a single commit, could you help approve it now? |
Could you please fix the merge conflict? |
082116f
to
c45ba94
Compare
hi @bogdandrutu! i just rebase and resolve the conflict, all tests pass now, could you help approve and merge it today? Thanks! |
Description:
This is a new health check method which allow customers to monitor the health status of containers based on the exporter functionally failures. It will return a 200/500 status when call the endpoint based on if the components can send data to the destination properly. Currently it only supports monitoring the exporter health status, will also support receivers and processors in the future.
Link to tracking Issue:
open-telemetry/opentelemetry-collector#2573
Testing:
make otelcontribcol
and run executable fileDocumentation:
https://docs.google.com/document/d/1SpUMsWA2DeaoVazeQ8uEc1Wvu5LphmQU_TjzLmuJ4QM/edit#heading=h.rs1luwizct2w
original pr was creating a new health check extension, but some community members think we should add the new feature in the existing one. Had discussion with @bogdandrutu and @Aneurysm9 and create this new pr.
previous pr:
#5144