Add device label to paging scraper. #4854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarker25
force-pushed
the
swap-devices
branch
3 times, most recently
from
ccf91ad to
1d3a09d
Compare
tbarker25
force-pushed
the
swap-devices
branch
from
1d3a09d to
6434486
Compare
tbarker25
force-pushed
the
swap-devices
branch
4 times, most recently
from
ad367a9 to
67a5ffa
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dashpole
approved these changes
Sep 14, 2021
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/pagefile_openbsd.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/pagefile_freebsd.go
Outdated
Show resolved
Hide resolved
|
Looks like this might need a merge / rebase. @tbarker25 - Could you help with that? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Please resolve the conflicts and address/resolve the open comments. |
Support BSDs and Solaris can be a future enhancement
|
@tigrannajaryan this is ready for review. |
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/pagefile_linux.go
Outdated
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/pagingscraper/pagefile_linux.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Extend paging scraper to collect per-device paging stats on Linux -- this will match the behavior for Windows. See tracking issue for more details.
Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector/issues/3447
Testing: Unit tests extended for this case.
Note this PR is moved from opentelemetry-collector: open-telemetry/opentelemetry-collector#3771