Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ComponentDocs test to internal/common and go mod tidy #415

Merged

Conversation

james-bebbington
Copy link
Member

No description provided.

@bogdandrutu
Copy link
Member

I would keep in in internal not internal/common. The reason is that we probably want this to not be included in the deps if someone depends on the internal/common (different go mod/sum)

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #415 into master will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   83.72%   84.64%   +0.91%     
==========================================
  Files         176      174       -2     
  Lines        9360     9365       +5     
==========================================
+ Hits         7837     7927      +90     
+ Misses       1210     1115      -95     
- Partials      313      323      +10     
Flag Coverage Δ
#integration 71.09% <ø> (?)
#unit 84.44% <ø> (+0.71%) ⬆️
Impacted Files Coverage Δ
cmd/otelcontribcol/components.go
cmd/otelcontribcol/main.go
cmd/otelcontribcol/main_others.go
internal/common/testing/container/container.go 73.80% <0.00%> (ø)
receiver/redisreceiver/factory.go 40.00% <0.00%> (+40.00%) ⬆️
receiver/redisreceiver/receiver.go 89.47% <0.00%> (+89.47%) ⬆️
receiver/redisreceiver/client.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34888b...5052a62. Read the comment docs.

@bogdandrutu bogdandrutu merged commit d2861ad into open-telemetry:master Jul 9, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
* Remove uses of zap.SugaredLogger from Prometheus receiver

* Update log message for unexpected point type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants