Remove zipkin scribe receiver and run go mod tidy everywhere #410
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
- Coverage 84.02% 83.99% -0.04%
==========================================
Files 178 176 -2
Lines 9529 9438 -91
==========================================
- Hits 8007 7927 -80
+ Misses 1196 1188 -8
+ Partials 326 323 -3
Continue to review full report at Codecov.
|
| @@ -27,6 +27,7 @@ contrib.go.opencensus.io/exporter/stackdriver v0.13.1/go.mod h1:z2tyTZtPmQ2HvWH4 | |||
| contrib.go.opencensus.io/resource v0.1.2 h1:b4WFJV8u7/NzPWHeTqj3Ec2AW8OGhtJxC/hbphIOvbU= | |||
| contrib.go.opencensus.io/resource v0.1.2/go.mod h1:F361eGI91LCmW1I/Saf+rX0+OFcigGlFvXwEGEnkRLA= | |||
| dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU= | |||
| git.apache.org/thrift.git v0.12.0/go.mod h1:fPE2ZNJGynbRyZ4dJvy6G277gSllfV2HJqblrnkyeyg= | |||
There was a problem hiding this comment.
Is this some fork of Thrift? Looks like it appeared after removing
replace git.apache.org/thrift.git v0.12.0 => github.com/apache/thrift v0.12.0
from go.mod above.
go mod graph shows that OpenCensus depends on it:
go.opencensus.io@v0.19.1 git.apache.org/thrift.git@v0.12.0
which is coming from this exporter:
github.com/signalfx/opencensus-go-exporter-kinesis@v0.4.2 go.opencensus.io@v0.19.1
There was a problem hiding this comment.
It is moved from line 96. Don't ask me why go mod tidy decided on this change.
There was a problem hiding this comment.
The latest Kinesis exporter release https://github.com/signalfx/opencensus-go-exporter-kinesis/releases/tag/v0.6.3 has a newer dependency on OpenCensus v0.22.2 so updating it should eliminate this dependency.
There was a problem hiding this comment.
Sorry, that replace was given me an error after I deleted the scribe. That's why I removed it.
There was a problem hiding this comment.
@nilebox please send a PR after this.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
* Add http observability metrics to Prometheus receiver * Add comment about http failure status and remove spurious log * Apply go fmt * Update log to be a warning rather than info
* Move envs into $BASH_ENV * AWS CLI orb
* Move envs into $BASH_ENV * AWS CLI orb
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Zipkin Scribe support was deprecated more than few years ago, and hard to find any documentation, found some PRs related in go-kit go-kit/kit@48b4028#diff-bec2cc44db2f273eb2db7579a445378e
Edit: Scribe is not officially deprecated but not used that much, see https://groups.google.com/forum/#!topic/zipkin-user/0XN7G2gArUc
Fixes: #409