Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Export spans to hec (#359)" #375

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Jun 30, 2020

This reverts commit 625973a.

Reverting because this fails the build https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/1563/workflows/e7c13c24-34ac-4fa6-85e9-da3fafb0fbbc and we have to make a release now.

@tigrannajaryan tigrannajaryan requested a review from a team June 30, 2020 16:23
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #375 into master will increase coverage by 20.59%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #375       +/-   ##
===========================================
+ Coverage   63.31%   83.90%   +20.59%     
===========================================
  Files          16      178      +162     
  Lines         676     9520     +8844     
===========================================
+ Hits          428     7988     +7560     
- Misses        224     1203      +979     
- Partials       24      329      +305     
Flag Coverage Δ
#integration 63.31% <ø> (ø)
#unit 83.70% <100.00%> (?)
Impacted Files Coverage Δ
exporter/splunkhecexporter/client.go 84.90% <ø> (ø)
exporter/splunkhecexporter/exporter.go 95.65% <100.00%> (ø)
exporter/splunkhecexporter/factory.go 100.00% <100.00%> (ø)
exporter/splunkhecexporter/metricdata_to_splunk.go 74.48% <100.00%> (ø)
receiver/collectdreceiver/collectd.go 92.45% <0.00%> (ø)
exporter/signalfxexporter/factory.go 100.00% <0.00%> (ø)
extension/observer/k8sobserver/handler.go 74.39% <0.00%> (ø)
exporter/awsxrayexporter/translator/writer_pool.go 91.66% <0.00%> (ø)
receiver/receivercreator/receivermap.go 100.00% <0.00%> (ø)
receiver/k8sclusterreceiver/receiver.go 62.50% <0.00%> (ø)
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625973a...988c760. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 891b1bc into open-telemetry:master Jun 30, 2020
@tigrannajaryan tigrannajaryan deleted the feature/tigran/revertcommit branch June 30, 2020 16:34
atoulme added a commit to atoulme/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2020
tigrannajaryan pushed a commit that referenced this pull request Jul 6, 2020
* Revert "Revert "Export spans to hec (#359)" (#375)"

This reverts commit 891b1bc.

This unreverts the revert of #359, now that the release is out.
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
* Revert "Revert "Export spans to hec (#359)" (#375)"

This reverts commit 891b1bc.

This unreverts the revert of #359, now that the release is out.
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
* Use strict mode to read config

Reading the config using exact matches causes errors for unknown sections reducing the changes of accidental errors on the configuration files.

* Add comments and fix testbed config files
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Change all occurrences of value to pointer receivers
Add meta sys files to .gitignore
Code cleanup e.g.
- Don't capitalize error statements
- Fix ignored errors
- Fix ambiguous variable naming
- Remove unnecessary type casting
- Use named params

Fix #306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants