-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Export spans to hec (#359)" #375
Merged
tigrannajaryan
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/revertcommit
Jun 30, 2020
Merged
Revert "Export spans to hec (#359)" #375
tigrannajaryan
merged 1 commit into
open-telemetry:master
from
tigrannajaryan:feature/tigran/revertcommit
Jun 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 625973a. Reverting because this fails the build https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/1563/workflows/e7c13c24-34ac-4fa6-85e9-da3fafb0fbbc and we have to make a release now.
bogdandrutu
approved these changes
Jun 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
===========================================
+ Coverage 63.31% 83.90% +20.59%
===========================================
Files 16 178 +162
Lines 676 9520 +8844
===========================================
+ Hits 428 7988 +7560
- Misses 224 1203 +979
- Partials 24 329 +305
Continue to review full report at Codecov.
|
atoulme
added a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2020
tigrannajaryan
pushed a commit
that referenced
this pull request
Jul 6, 2020
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
This reverts commit 625973a. Reverting because this fails the build https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/1563/workflows/e7c13c24-34ac-4fa6-85e9-da3fafb0fbbc and we have to make a release now.
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
* Use strict mode to read config Reading the config using exact matches causes errors for unknown sections reducing the changes of accidental errors on the configuration files. * Add comments and fix testbed config files
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
Change all occurrences of value to pointer receivers Add meta sys files to .gitignore Code cleanup e.g. - Don't capitalize error statements - Fix ignored errors - Fix ambiguous variable naming - Remove unnecessary type casting - Use named params Fix #306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 625973a.
Reverting because this fails the build https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/1563/workflows/e7c13c24-34ac-4fa6-85e9-da3fafb0fbbc and we have to make a release now.