[receiver/azuremonitorreceiver] feat: multi subscriptions support and automatic discovery #37167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… automatic discovery Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>
6 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
jmacd
approved these changes
Feb 10, 2025
Comment on lines
+262
to
+263
| if c.SubscriptionID == "" && len(c.SubscriptionIDs) == 0 && !c.DiscoverSubscriptions { | ||
| err = multierr.Append(err, errMissingSubscriptionIDs) |
There was a problem hiding this comment.
Does it ever make sense to allow more than one of these three modes to be configured? Maybe have an error is more than one setting exists?
There was a problem hiding this comment.
Yeah to be honest I'm even thinking of introducing a breaking change 😅 like changing subscription id into subscription IDs and that's it. It's still an alpha receiver
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
This was referenced Feb 11, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated from a diffferent fork. Context: #36467