-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/encoding] support skywalkingencoding extension #36968
base: main
Are you sure you want to change the base?
[extension/encoding] support skywalkingencoding extension #36968
Conversation
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
8d1b0e5
to
b01b7a1
Compare
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
…edTan95/opentelemetry-collector-contrib into skywalkingencoding_extension
@atoulme https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/12555637724/job/35005905911?pr=36968#step:5:18 Looks like code owners can't be removed |
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know how to fix the check-owners failed lint?
logs show that I need to do some changes: - extension/encoding/ @open-telemetry/collector-contrib-approvers @atoulme @dao-jun @dmitryax @MovieStoreGuy @VihasMakwana
+ extension/encoding/ @open-telemetry/collector-contrib-approvers @atoulme @dao-jun @dmitryax @MovieStoreGuy @VihasMakwana @JaredTan95 in |
This is the current action failure output:
It's simply missing a line for the new extension you're adding, it's no longer complaining about the |
Signed-off-by: Jared Tan <jian.tan@daocloud.io> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36968 +/- ##
==========================================
- Coverage 79.59% 79.59% -0.01%
==========================================
Files 2252 2255 +3
Lines 211914 211940 +26
==========================================
+ Hits 168682 168699 +17
- Misses 37562 37571 +9
Partials 5670 5670 ☔ View full report in Codecov by Sentry. |
Description
The
kafkareceiver
supportsjaeger
andzipkin
protocol traces, and can also receive skywalkng traces viaskywalkingreceiver
.From the practical use of skywalking, we often use kafka to host large-scale traces data. However,
kafka receiver
does not supportskywalking encoding
currently.with this PR, we can fectch skywalking traces and parse it into
otlp
traces:Link to tracking issue
Fixes #28693
Testing
Documentation