Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: enable gofumpt linter for processor #36347

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[chore]: enable gofumpt linter for processor #36347

merged 1 commit into from
Nov 13, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 13, 2024 •
edited by andrzej-stencel
Loading

Description

gofumpt enforces a stricter format than gofmt

Part of #36363

@github-actions github-actions bot added processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/deltatocumulative processor/deltatorate Delta To Rate processor processor/filter Filter processor processor/groupbyattrs Group By Attributes processor processor/groupbytrace Group By Trace processor processor/interval processor/k8sattributes k8s Attributes processor processor/logdedup processor/logstransform Logs Transform processor processor/metricsgeneration Metrics Generation processor processor/metricstransform Metrics Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/redaction Redaction processor processor/remotetap processor/resourcedetection Resource detection processor labels Nov 13, 2024
@mmorel-35 mmorel-35 force-pushed the gofumpt/processor branch 2 times, most recently from c07b8e8 to 071a128 Compare November 13, 2024 17:50
mx-psi
mx-psi reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will there be any way to autofix format to make it gofumpt compliant after this PR is merged?

@mmorel-35
[chore]: enable gofumpt linter for processor
fe0e99f 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

Like I did with Whitespace linter, it is applied through several PR across the whole project. Then the linter is globally enabled in the golangci config.Then can be auto fixed through IDE configuration or Make rules

@mmorel-35 mmorel-35 mentioned this pull request Nov 13, 2024
Closed
9 tasks
@bogdandrutu bogdandrutu merged commit 6db5d1a into open-telemetry:main Nov 13, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 13, 2024
@mmorel-35 mmorel-35 deleted the gofumpt/processor branch November 14, 2024 06:02
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@mmorel-35 @sbylica-splunk
[chore]: enable gofumpt linter for processor (open-telemetry#36347)
90d4441 
#### Description

[gofumpt](https://golangci-lint.run/usage/linters/#gofumpt) enforces a
stricter format than gofmt

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi left review comments

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@boostchicken boostchicken Awaiting requested review from boostchicken

@chan-tim-sumo chan-tim-sumo Awaiting requested review from chan-tim-sumo

@dehaansa dehaansa Awaiting requested review from dehaansa

@jaronoff97 jaronoff97 Awaiting requested review from jaronoff97

@kentquirk kentquirk Awaiting requested review from kentquirk

@MikeGoldsmith MikeGoldsmith Awaiting requested review from MikeGoldsmith

@RichieSams RichieSams Awaiting requested review from RichieSams

@rnishtala-sumo rnishtala-sumo Awaiting requested review from rnishtala-sumo

@sh0rez sh0rez Awaiting requested review from sh0rez

Assignees

@jpkrohling jpkrohling

Labels
processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/deltatocumulative processor/deltatorate Delta To Rate processor processor/filter Filter processor processor/groupbyattrs Group By Attributes processor processor/groupbytrace Group By Trace processor processor/interval processor/k8sattributes k8s Attributes processor processor/logdedup processor/logstransform Logs Transform processor processor/metricsgeneration Metrics Generation processor processor/metricstransform Metrics Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/redaction Redaction processor processor/remotetap processor/resource Resource processor processor/resourcedetection Resource detection processor processor/routing Routing processor processor/span processor/sumologic processor/tailsampling Tail sampling processor processor/transform Transform processor
Projects
None yet
Milestone
v0.114.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorel-35 @bogdandrutu @mx-psi @jpkrohling