Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input operator stop must not crash even if start was not called #36262

Merged
merged 10 commits into from
Nov 8, 2024
Merged

Input operator stop must not crash even if start was not called #36262

merged 10 commits into from
Nov 8, 2024

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Nov 7, 2024 •
edited by songy23
Loading

The Input operator for Windows is crashing if Start was not called before calling Stop, this should be supported.

This was detected via TestCreateAndShutdown failures, e.g.: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11725367982/job/32661488243#step:8:229

Fixes #36268

@pjanotti pjanotti added the Run Windows Enable running windows test on a PR label Nov 7, 2024
@github-actions github-actions bot requested a review from djaglowski November 7, 2024 17:29
@pjanotti pjanotti added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 7, 2024
@pjanotti pjanotti marked this pull request as ready for review November 7, 2024 17:39
@pjanotti pjanotti requested a review from a team as a code owner November 7, 2024 17:39
@pjanotti pjanotti changed the title Input operator should stop no crash even if start was not called Input operator should stop not crash even if start was not called Nov 7, 2024
@pjanotti pjanotti changed the title Input operator should stop not crash even if start was not called Input operator stop must not crash even if start was not called Nov 7, 2024
songy23
songy23 reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@VihasMakwana
Copy link
Contributor

dbstorage unit tests are failing. Strange.
Looks unrelated to the PR though

@songy23
Copy link
Member

songy23 commented Nov 8, 2024

dbstorage test should be fixed in #36267

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Nov 8, 2024
@djaglowski djaglowski merged commit 9c382d9 into open-telemetry:main Nov 8, 2024
173 of 174 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 8, 2024
@pjanotti pjanotti deleted the stanza-windows-input-operator-stop-fix branch November 8, 2024 17:06
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this pull request Nov 8, 2024
@pjanotti @pull
Input operator stop must not crash even if start was not called (open…
70bf092 
…-telemetry#36262)
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@pjanotti @sbylica-splunk
Input operator stop must not crash even if start was not called (open…
ea1bcd2 
…-telemetry#36262)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@songy23 songy23 songy23 approved these changes

@VihasMakwana VihasMakwana VihasMakwana approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees

@jpkrohling jpkrohling

Labels
pkg/stanza ready to merge Code review completed; ready to merge by maintainers Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.114.0
Development

Successfully merging this pull request may close these issues.

[Flakey test][pkg/stanza] TestCreateAndShutdown leads to nil pointer on Windows
6 participants
@pjanotti @VihasMakwana @songy23 @atoulme @jpkrohling @djaglowski