-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][exporter/azuremonitor] Force the telemetry to be sent to azuremonitor #36172
[chore][exporter/azuremonitor] Force the telemetry to be sent to azuremonitor #36172
Conversation
Signed-off-by: whitneygriffith <whitney.griffith16@gmail.com>
Sounds like this is a bug fix. Can you add a changelog entry? https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-a-changelog-entry |
Signed-off-by: whitneygriffith <whitney.griffith16@gmail.com>
I have added the changelog entry. |
There are some errors here: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11700948723/job/32586089416?pr=36172
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some unresolved failed tests https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11711127058/job/32641600088?pr=36172
=== FAIL: . TestExporterLogDataCallback (0.00s)
panic:
assert: mock: I don't know what to return because the method call was unexpected.
Either do Mock.On("Flush").Return(...) first, or remove the Flush() call.
This method was unexpected:
Flush()
at: [/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/azuremonitorexporter/mock_transportChannel.go:24 /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/azuremonitorexporter/logexporter.go:39 /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/azuremonitorexporter/logexporter_test.go:118] [recovered]
panic:
assert: mock: I don't know what to return because the method call was unexpected.
Either do Mock.On("Flush").Return(...) first, or remove the Flush() call.
This method was unexpected:
Flush()
at: [/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/azuremonitorexporter/mock_transportChannel.go:24 /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/azuremonitorexporter/logexporter.go:39 /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/azuremonitorexporter/logexporter_test.go:118]
aa13361
to
2dadef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should do as this lint said, could you please fix this? https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11904647742/job/33173837807?pr=36172
Generated code is out of date, please run "make generate" and commit the changes in this PR.
Signed-off-by: whitneygriffith <whitney.griffith16@gmail.com>
577b68d
to
5d45d87
Compare
Closing and re-opening as it looks like the CI checks are stuck. |
@whitneygriffith How about you create a same pr again? It seems that this pr is not able to be merged due to the stuck CI. |
Created #36520 |
Description
Link to tracking issue
Resolves #35037