[exporter/elasticsearch] Enable gzip compression by default #35865
Conversation
| if cfg.Compression != "" { | ||
| // TODO support confighttp.ClientConfig.Compression | ||
| return errors.New("compression is not currently configurable") | ||
| if cfg.Compression != "none" && cfg.Compression != configcompression.TypeGzip { |
There was a problem hiding this comment.
TypeNone should work? https://github.com/open-telemetry/opentelemetry-collector/blob/v0.111.0/config/configcompression/compressiontype.go#L17
| if cfg.Compression != "none" && cfg.Compression != configcompression.TypeGzip { | |
| if cfg.Compression != configcompression.TypeNone && cfg.Compression != configcompression.TypeGzip { |
There was a problem hiding this comment.
We should also probably treat empty value "" (TypeEmpty) as valid.
There was a problem hiding this comment.
notice it is lowercase typeNone, not TypeNone, therefore it will not be possible to be referenced from es exporter.
There was a problem hiding this comment.
We should also probably treat empty value "" (TypeEmpty) as valid.
With a non-empty default, I don't think it is possible to set it to empty.
There was a problem hiding this comment.
TestExporterMetrics in elasticsearch exporter has been flaky on Windows since this commit e.g. https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11453791269/job/31866855448 May be related
…emetry#35865) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Enable gzip compression by default, at hardcoded level BestSpeed. To disable compression, set `compression` to `none`. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.-->
Description
Enable gzip compression by default, at hardcoded level BestSpeed. To disable compression, set
compressiontonone.Link to tracking issue
Testing
Documentation