Add s3 storage class to the AWS S3 exporter #35574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollosp
changed the title
remove unuseful comment
|
im still waiting :D |
|
"I’m really looking forward to this feature release as soon as possible. Please review it soon, @atoulme." |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme anything else required for merge this? |
hoazgazh
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add s3 storage class
Link to tracking Issue: #35173
Testing: Unit for the config interface
Documentation: Added storage class for the S3