Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/nginx] Use NewDefaultClientConfig instead of manually creating struct #35452

Merged
merged 7 commits into from
Oct 9, 2024
Merged

[receiver/nginx] Use NewDefaultClientConfig instead of manually creating struct #35452

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0d446a
[receiver/nginx] Use NewDefaultClientConfig instead of manually creat…
ChrsMark Sep 27, 2024
c54c7fa
Merge branch 'main' into nginx_use_NewDefaultClientConfig
ChrsMark Sep 30, 2024
a7fe415
Merge branch 'main' into nginx_use_NewDefaultClientConfig
ChrsMark Oct 1, 2024
ca6a973
remove nil initialization
ChrsMark Oct 1, 2024
f841117
Merge branch 'main' into nginx_use_NewDefaultClientConfig
ChrsMark Oct 2, 2024
68f9b15
Merge branch 'main' into nginx_use_NewDefaultClientConfig
ChrsMark Oct 4, 2024
be7f247
Merge branch 'main' into nginx_use_NewDefaultClientConfig
ChrsMark Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions receiver/nginxreceiver/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@ func createDefaultConfig() component.Config {
cfg := scraperhelper.NewDefaultControllerConfig()
cfg.CollectionInterval = 10 * time.Second

clientConfig := confighttp.NewDefaultClientConfig()
clientConfig.Endpoint = "http://localhost:80/status"
clientConfig.Timeout = 10 * time.Second

return &Config{
ControllerConfig: cfg,
ClientConfig: confighttp.ClientConfig{
Endpoint: "http://localhost:80/status",
Timeout: 10 * time.Second,
},
ControllerConfig: cfg,
ClientConfig: clientConfig,
MetricsBuilderConfig: metadata.DefaultMetricsBuilderConfig(),
}
}
Expand Down