[exporter/azuredataexplorerexporter]: Fixes ingestion issue due to compression prop missing #35354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bugfix] : ingestion prop compressionType added
ag-ramachandran
approved these changes
Sep 23, 2024
|
Hi @andrzej-stencel Gentle reminder for a review on the PR |
|
@dmitryax @andrzej-stencel please review the PR. |
|
Would it be worth it to document this in the component's README? If this could cause any unexpected results for users it may be worth it, but I'm relying on the expertise of others here to know if it's necessary or not. |
|
Hi @crobert-1 This is an internal change that is not impacting the end users. I think documentation is not required since this is a bugfix. |
|
Hi @dmitryax this is critical fix for us, can we get someone to approve and merge this fix? |
andrzej-stencel
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Data Ingestion to ADX failure fix, by adding a compression prop in ingestion properties
Link to tracking Issue:
#35353
Testing:
Successful ingestions
Documentation:
No Doc required